[webkit-reviews] review denied: [Bug 51626] [EFL] Change the tiled backing store to use constant tile size. : [Attachment 77470] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rafael Antognolli
<antognolli at profusion.mobi>'s request for review:
Bug 51626: [EFL] Change the tiled backing store to use constant tile size.
https://bugs.webkit.org/show_bug.cgi?id=51626

Attachment 77470: Patch
https://bugs.webkit.org/attachment.cgi?id=77470&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77470&action=review

The patch seems to look good. Anyway it seems not to apply to svn. So you have
to update the patch anyway. Just some general comments. While t is even better,
it would be much easier to understand the code if you take self explaining
names: t -> tile tw tile_width and so on. Because all these names were used in
other contexts in the past on other parts of WebCore. (t for transform and so
on)

> WebKit/efl/ewk/ewk_tiled_backing_store.c:1443
> +    if (!priv->render.suspend
> +	   && (priv->changed.model
> +	       || priv->changed.layout)) {

This can be moved into one line, or at least in two lines for readability