[webkit-reviews] review denied: [Bug 58503] Make more functions static local in EventHandlers.cpp : [Attachment 89598] cleanup

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 58503: Make more functions static local in EventHandlers.cpp
https://bugs.webkit.org/show_bug.cgi?id=58503

Attachment 89598: cleanup
https://bugs.webkit.org/attachment.cgi?id=89598&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89598&action=review

r- based mostly on the previous comments

> Source/WebCore/page/EventHandler.cpp:2519
> +    DEFINE_STATIC_LOCAL(AtomicString, Down, ("Down"));
> +    DEFINE_STATIC_LOCAL(AtomicString, Up, ("Up"));
> +    DEFINE_STATIC_LOCAL(AtomicString, Left, ("Left"));
> +    DEFINE_STATIC_LOCAL(AtomicString, Right, ("Right"));

I know you're just moving this code, but these variable names should be
lowercase.

Also, is it worth putting these in a map?