[webkit-reviews] review granted: [Bug 59266] DFG JIT - Add SSA style DCE : [Attachment 90825] Errrk! - bad patch, fixed version.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 59266: DFG JIT - Add SSA style DCE
https://bugs.webkit.org/show_bug.cgi?id=59266

Attachment 90825: Errrk! - bad patch, fixed version.
https://bugs.webkit.org/attachment.cgi?id=90825&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90825&action=review

r=me

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1012
> +	   for (unsigned i =0; i < predecessors.size(); ++i) {

Style nit: =0.

> Source/JavaScriptCore/dfg/DFGNonSpeculativeJIT.cpp:651
> +	   // should never be reached.
> +	   CRASH();

Can we use ASSERT_NOT_REACHED here and remove the comment?

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:838
> +    case Phi:
> +	   // should never be reached.
> +	   CRASH();

Ditto.