[webkit-reviews] review granted: [Bug 59240] rebaseline-chromium-webkit-tests: clean up output : [Attachment 90820] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 22 19:03:55 PDT 2011
Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 59240: rebaseline-chromium-webkit-tests: clean up output
https://bugs.webkit.org/show_bug.cgi?id=59240
Attachment 90820: Patch
https://bugs.webkit.org/attachment.cgi?id=90820&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90820&action=review
> Tools/Scripts/webkitpy/common/checkout/scm.py:716
> + return return_code != 128
128 seems like a magical number here. Can we name the constant?
More information about the webkit-reviews
mailing list