[webkit-reviews] review granted: [Bug 58852] [GTK] Add proxy support to GtkLauncher : [Attachment 90675] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 58852: [GTK] Add proxy support to GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=58852

Attachment 90675: Patch
https://bugs.webkit.org/attachment.cgi?id=90675&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90675&action=review

Okay. This seems alright in the end.

> Tools/ChangeLog:9
> +	   * GtkLauncher/main.c:
> +	   (main):

Please fill this out before landing.

> Tools/GtkLauncher/main.c:245
> +    const char *httpProxy = getenv("http_proxy");

I think it would be better to call g_getenv here instead.