[webkit-reviews] review granted: [Bug 59168] LayoutTestResults should know how to handle NRWT json files : [Attachment 90657] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 59168: LayoutTestResults should know how to handle NRWT json files
https://bugs.webkit.org/show_bug.cgi?id=59168

Attachment 90657: Patch
https://bugs.webkit.org/attachment.cgi?id=90657&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90657&action=review

> Tools/Scripts/webkitpy/common/net/resultsjsonparser.py:82
> +	   elif actual == test_expectations.MISSING:
> +	       return [test_failures.FailureMissingResult(),
test_failures.FailureMissingImageHash(), test_failures.FailureMissingImage()]

This is an AND or an OR?

> Tools/Scripts/webkitpy/common/net/resultsjsonparser.py:107
> +	   return itertools.ifilter(lambda a: a, non_passing_results)

I don't understand what ifilter does.  Can we just use normal filter?