[webkit-reviews] review granted: [Bug 59108] Web Inspector: group content scripts in the scripts panel drop down. : [Attachment 90547] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 22 05:37:38 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 59108: Web Inspector: group content scripts in the scripts panel drop down.
https://bugs.webkit.org/show_bug.cgi?id=59108

Attachment 90547: Patch
https://bugs.webkit.org/attachment.cgi?id=90547&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90547&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:292
> +	       if (a.isContentScript && !b.isContentScript)

you could use difference between two boolean values instead of these two
statements:

var d = !!a.isContentScript - !!b.isContentScript;
if (!d) return d;


More information about the webkit-reviews mailing list