[webkit-reviews] review granted: [Bug 59176] Don't do manually style resolution for SVGElements with renderer : [Attachment 90670] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 59176: Don't do manually style resolution for SVGElements with renderer
https://bugs.webkit.org/show_bug.cgi?id=59176

Attachment 90670: Patch
https://bugs.webkit.org/attachment.cgi?id=90670&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90670&action=review

Excellent cleanup, r=me.

> Source/WebCore/ChangeLog:11
> +	   Don't do manually style resolution for SVGElements with renderer.
Instead get RenderStyle
> +	   from the renderer.

Don't resolve style manually, instead ask the RenderObject for its style.

> Source/WebCore/ChangeLog:13
> +	   Removed SVG element names from SVG attribute list.

Cleanup svgattrs.in, some SVG element names were accidently listed there as
attributes.