[webkit-reviews] review granted: [Bug 58926] BitmapImage::destroyMetadataAndNotify should clear m_checkedForSolidColor : [Attachment 90272] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 58926: BitmapImage::destroyMetadataAndNotify should clear
m_checkedForSolidColor
https://bugs.webkit.org/show_bug.cgi?id=58926

Attachment 90272: Patch
https://bugs.webkit.org/attachment.cgi?id=90272&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90272&action=review

r=me either way

> Source/WebCore/platform/graphics/BitmapImage.h:167
> +#if !ASSERT_DISABLED
> +    void assertNotSolidColor()
> +    {
> +	   ASSERT(size().width() != 1 || size().height() != 1 || frameCount() >
1);
> +    }
> +#endif

You could make this notSolidColor() const...

> Source/WebCore/platform/graphics/cg/ImageCG.cpp:273
> +	   static_cast<BitmapImage*>(this)->assertNotSolidColor();

... and here just ASSERT(notSolidColor())