[webkit-reviews] review requested: [Bug 58937] [Qt][WK2] Initial support for favicons. : [Attachment 90273] Proposed patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has asked  for review:
Bug 58937: [Qt][WK2] Initial support for favicons.
https://bugs.webkit.org/show_bug.cgi?id=58937

Attachment 90273: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=90273&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Proposed patch.

This does not cover the case where an icon is in already in the cache, though
this could be added in a follow-up patch. QWebFrame::iconChanged() didn't work
like that until very recently either.. :)

@Brady: In Qt's WebKit1 API, we always emit the iconChanged() signal, also
after an icon is retrieved from cache. Do you have any suggestions how to
accomplish this in WebKit2?