[webkit-reviews] review denied: [Bug 56924] [Qt] Fix Api tests for QWebPage on symbian : [Attachment 87599] updated with Alexis's suggestion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 15 14:17:41 PDT 2011


Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 56924: [Qt] Fix Api tests for QWebPage on symbian
https://bugs.webkit.org/show_bug.cgi?id=56924

Attachment 87599: updated with Alexis's suggestion
https://bugs.webkit.org/attachment.cgi?id=87599&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
I do not think autotests should be sensitive to platform fonts. I would rather
modify the tests so that it simply ignores the style. 

For font-sensitive tests we should use LayoutTests which has a mechanism of
platform dependent expected results.

Yi, can you change the test so that it ignores the style that selectedHtml()
returns ?


More information about the webkit-reviews mailing list