[webkit-reviews] review denied: [Bug 58679] The GTest framework should not use MacOSX10.4u.sdk : [Attachment 89851] Fixing gtest configuration

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Dmitry Lomov <dslomov at google.com>'s
request for review:
Bug 58679: The GTest framework should not use MacOSX10.4u.sdk
https://bugs.webkit.org/show_bug.cgi?id=58679

Attachment 89851: Fixing gtest configuration
https://bugs.webkit.org/attachment.cgi?id=89851&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89851&action=review

README.WebKit is good but you still need a ChangeLog.

> Source/ThirdParty/gtest/xcode/Config/General.xcconfig:39
> +// number.  Newer versions of Xcode use XCODE_VERSION_MINOR for the minor
version, and

Single space after . for WebKit.

> Source/ThirdParty/gtest/xcode/Config/General.xcconfig:63
> +// If the target Mac OS X version does not match the current Mac OS X
version then we'll want to build using the target version's SDK.

Add , before then.