[webkit-reviews] review granted: [Bug 58596] WK2: Past searches not remembered for <input type=search results="5" autosave="foo"> : [Attachment 89810] Patch v1

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Brady Eidson <beidson at apple.com>'s request for
review:
Bug 58596: WK2: Past searches not remembered for <input type=search results="5"
autosave="foo">
https://bugs.webkit.org/show_bug.cgi?id=58596

Attachment 89810: Patch v1
https://bugs.webkit.org/attachment.cgi?id=89810&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=89810&action=review

> Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:191
> +    // The WebProcess shouldnt have bothered to send this message if the
name was empty.

Typo: shouldnt.

> Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:197
> +    size_t size = searchItems.size();
> +    if (size) {

size can be defined inside the if().

> Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:211
> +    // The WebProcess shouldnt have bothered to send this message if the
name was empty.

Same typo!!