[webkit-reviews] review granted: [Bug 57092] [Qt] QNetworkReplyHandler refactoring: some adjustments : [Attachment 89822] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 15 12:11:06 PDT 2011


Andreas Kling <kling at webkit.org> has granted Luiz Agostini <luiz at webkit.org>'s
request for review:
Bug 57092: [Qt] QNetworkReplyHandler refactoring: some adjustments
https://bugs.webkit.org/show_bug.cgi?id=57092

Attachment 89822: patch
https://bugs.webkit.org/attachment.cgi?id=89822&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89822&action=review

Another nice cleanup. :)

r=me with some minor fixes before landing:

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.h:78
> +    bool redirected() const { return m_redirectionTargetUrl.isValid(); }

wasRedirected() would read nicer IMO.

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.h:97
> +    int m_statusCode;

This is not used anywhere, should be removed.


More information about the webkit-reviews mailing list