[webkit-reviews] review denied: [Bug 58064] Web Inspector: Network events don't preserves, when inspector frontend closed and open again : [Attachment 89579] After firsts review. Functionality disabled by default

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Sergey Vorobyev
<sergeyvorobyev at google.com>'s request for review:
Bug 58064: Web Inspector: Network events don't preserves, when inspector
frontend closed and open again
https://bugs.webkit.org/show_bug.cgi?id=58064

Attachment 89579: After firsts review. Functionality disabled by default
https://bugs.webkit.org/attachment.cgi?id=89579&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89579&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:94
> +    if (enabledBackgoundEventsCoollection()) {

enabledBackgoundEventsCoollection -> backgoundEventsCoollectionEnabled

> Source/WebCore/inspector/InspectorResourceAgent.cpp:-281
> -    ASSERT(!m_instrumentingAgents->inspectorResourceAgent());

This assert should be preserved if it fails you should figure out when to clear
pointer to this agent from the instrumenting agents structure.

> Source/WebCore/inspector/InspectorResourceAgent.cpp:504
> +    // TODO(vors):

Please file a bug on this and add FIXME(bug number) instead of the TODO.

> Source/WebCore/inspector/InspectorResourceAgent.h:134
> +    OwnPtr<InspectorFrontend::Network> m_frontend;

This is wrong since the frontend passed in setFrontend method is owned by the
caller, r- for this.