[webkit-reviews] review denied: [Bug 32865] [Qt] QWebElement::attribute always returns empty result for input's values : [Attachment 89729] attribute/setAttribute patch to be compatible with html inputs' values

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied wolfy <wolfram at ritsuka.org>'s
request for review:
Bug 32865: [Qt] QWebElement::attribute always returns empty result for input's
values
https://bugs.webkit.org/show_bug.cgi?id=32865

Attachment 89729: attribute/setAttribute patch to be compatible with html
inputs' values
https://bugs.webkit.org/attachment.cgi?id=89729&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89729&action=review

R-: Missing changelog, and missing tests.
The idea look sane though, is value the only attribute behaving like that?

> B/qwebelement.cpp:127
> +

Empty line?