[webkit-reviews] review granted: [Bug 57954] [Qt] Height of "Ahem" font differs from all other ports. : [Attachment 89231] Proposed patch v2

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 57954: [Qt] Height of "Ahem" font differs from all other ports.
https://bugs.webkit.org/show_bug.cgi?id=57954

Attachment 89231: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=89231&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89231&action=review

> Source/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp:66
> +    // QFontMetricsF::leading() may return negative values on platforms
> +    // such as FreeType. Calculate the line gap manually instead.

Platform such as freetype?