[webkit-reviews] review granted: [Bug 58353] Set minimum priority for fast lane connections : [Attachment 89240] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 58353: Set minimum priority for fast lane connections
https://bugs.webkit.org/show_bug.cgi?id=58353

Attachment 89240: Patch
https://bugs.webkit.org/attachment.cgi?id=89240&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89240&action=review

r=me

> Source/JavaScriptCore/wtf/Platform.h:404
>#if OS(DARWIN) && ((defined(TARGET_OS_EMBEDDED) && TARGET_OS_EMBEDDED)  \
>      || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)		    \
>      || (defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR))
>  #define WTF_OS_IOS 1
> +#define BUILDING_ON_IOS 1

As I just found out:

TARGET_OS_IPHONE is set to "1" for both iOS hardware and iOS Simulator builds,
so just checking that would be sufficient.  We don't need to check for
TARGET_OS_EMBEDDED or TARGET_IPHONE_SIMULATOR here.

If you want to clean up the definition for WTF_PLATFORM_IOS and
WTF_PLATFORM_IOS_SIMULATOR below at the same time, that would be great, but not
necessary.

WTF_PLATFORM_IOS only needs to check for TARGET_OS_IPHONE being 1, and
WTF_PLATFORM_IOS_SIMULATOR only needs to check for TARGET_IPHONE_SIMULATOR
being 1.