[webkit-reviews] review granted: [Bug 58379] The default backspace event handler should mark the event as handled if navigation succeeds : [Attachment 89282] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 15:36:10 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has granted Ananta Iyengar
<ananta at chromium.org>'s request for review:
Bug 58379: The default backspace event handler should mark the event as handled
if navigation succeeds
https://bugs.webkit.org/show_bug.cgi?id=58379

Attachment 89282: Initial patch
https://bugs.webkit.org/attachment.cgi?id=89282&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89282&action=review

> Source/WebCore/ChangeLog:3
> +	   https://bugs.webkit.org/show_bug.cgi?id=58379

Please add bug title before the link.

> Source/WebCore/ChangeLog:9
> +	   No new tests. (OOPS!)

The patch cannot be landed with OOPS, so you need to explain why there are no
new tests instead of leaving the line as is.


More information about the webkit-reviews mailing list