[webkit-reviews] review granted: [Bug 58382] Infinite recursion in WebHTMLView executeSavedKeypressCommands : [Attachment 89281] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 12 15:34:42 PDT 2011
Alexey Proskuryakov <ap at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 58382: Infinite recursion in WebHTMLView executeSavedKeypressCommands
https://bugs.webkit.org/show_bug.cgi?id=58382
Attachment 89281: Patch
https://bugs.webkit.org/attachment.cgi?id=89281&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89281&action=review
> Source/WebKit2/UIProcess/API/mac/WKView.mm:1183
> + // We could be called again if the execution of one command triggers a
call to selectedRange.
I would add: "In this case, the state is up to date, and we don't need to
execute any more saved commands to return a result"
More information about the webkit-reviews
mailing list