[webkit-reviews] review granted: [Bug 57818] [Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag. : [Attachment 88481] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 57818: [Chromium]Change menu list background fallback value to transparent
to work background:none for HTML select tag.
https://bugs.webkit.org/show_bug.cgi?id=57818

Attachment 88481: Patch
https://bugs.webkit.org/attachment.cgi?id=88481&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88481&action=review

In either case, this looks fine.

> Source/WebCore/rendering/RenderThemeChromiumLinux.cpp:278
> +    extraParams.menuList.backgroundColor = SkColorSetARGB(0, 0, 0, 0);

Do we not have a named SkColor for this?  Color::transparent would be the
WebCore way.