[webkit-reviews] review granted: [Bug 58060] Prepare access to TreeScope from Node, using NodeRareData : [Attachment 88869] new patch, added ASSERTs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 8 13:55:39 PDT 2011
Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 58060: Prepare access to TreeScope from Node, using NodeRareData
https://bugs.webkit.org/show_bug.cgi?id=58060
Attachment 88869: new patch, added ASSERTs
https://bugs.webkit.org/attachment.cgi?id=88869&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88869&action=review
pretty cool.
> Source/WebCore/ChangeLog:28
> + (WebCore::Document::setDocType): change DOM manipulation methods to
update scope of inserted nodes
You can just say "Ditto." here.
> Source/WebCore/ChangeLog:29
> + (WebCore::Document::adoptNode): change DOM manipulation methods to
update scope of inserted nodes
Ditto.
> Source/WebCore/dom/Node.cpp:478
> + // FIXME: until we land shadow scopes, there should be no non-document
scopes.
Capitalize U.
> Source/WebCore/dom/Node.cpp:521
> + // FIXME: once shadow scopes are landed, update parent scope, etc.
Capitalize O.
> Source/WebCore/dom/TreeScope.cpp:49
> + // FIXME: this branch should be inert until shadow scopes are
landed.
Capitalize T.
> Source/WebCore/dom/TreeScope.cpp:69
> + // Cannot reparent a document!
Take out the exclamation point, turn into a sentence. :)
More information about the webkit-reviews
mailing list