[webkit-reviews] review granted: [Bug 57987] new-run-webkit-tests: implement support for audio files : [Attachment 88756] split into two patches

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 10:48:58 PDT 2011

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 57987: new-run-webkit-tests: implement support for audio files

Attachment 88756: split into two patches

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88756&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:882
> +    def __init__(self, text=None, image=None, image_hash=None, audio=None,
> +		    crash=False, test_time=0, timeout=False, error=''):

Nit: Making all the params named parameters makes things noisier to me and it's
inconsistent with what we do for other functions.  I liked the old way better.

More information about the webkit-reviews mailing list