[webkit-reviews] review granted: [Bug 57843] Switch from Vector<UChar> to StringBuilder in dom/ : [Attachment 88225] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 10:44:54 PDT 2011

Andreas Kling <kling at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 57843: Switch from Vector<UChar> to StringBuilder in dom/

Attachment 88225: Patch

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88225&action=review

> Source/WebCore/dom/DatasetDOMStringMap.cpp:124
> +	       builder.append(toASCIILower(characters[i]));

Why characters[i] and not character? And why do you need the local regardless?

More information about the webkit-reviews mailing list