[webkit-reviews] review denied: [Bug 57765] WK2: PDF: Find in page : [Attachment 88151] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 23:59:35 PDT 2011

Maciej Stachowiak <mjs at apple.com> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 57765: WK2: PDF: Find in page

Attachment 88151: Patch

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88151&action=review

Looks like this is still breaking the windows build according to EWS, so r- for
that. Other than that, I don't see any obvious showstopper problems.

> Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:235
> +	   // Initially we want to include the selected text in the search.
PDFDocument's API always searches from just
> +	   // past the passed-in selection, so we need to pass a selection
that's modified appropriately.
> +	   // FIXME 4182863: Ideally we'd use a zero-length selection at the
edge of the current selection, but zero-length
> +	   // selections don't work in PDFDocument. So instead we make a
one-length selection just before or after the
> +	   // current selection, which works for our purposes even when the
current selection is at an edge of the
> +	   // document.

This comment is a bit verbose, any way to make it shorter?

More information about the webkit-reviews mailing list