[webkit-reviews] review granted: [Bug 57962] AVF: MediaPlayerPrivateAVFoundation never reaches playable state. : [Attachment 88516] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 23:45:26 PDT 2011


Maciej Stachowiak <mjs at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 57962: AVF: MediaPlayerPrivateAVFoundation never reaches playable state.
https://bugs.webkit.org/show_bug.cgi?id=57962

Attachment 88516: Patch
https://bugs.webkit.org/attachment.cgi?id=88516&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88516&action=review

r=me

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cp
p:-634
> -    LOG(Media,
"MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification(%p) -
notification %d", this, static_cast<int>(type));

Why remove this log call? Looks like it got copied to the new overload only,
which seems a bit odd.


More information about the webkit-reviews mailing list