[webkit-reviews] review requested: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 88532] Fix defines for WTF/JS_EXPORT_PRIVATE in !USE(EXPORT_MACROS) case
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 6 15:31:13 PDT 2011
Kevin Ollivier <kevino at theolliviers.com> has asked for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551
Attachment 88532: Fix defines for WTF/JS_EXPORT_PRIVATE in !USE(EXPORT_MACROS)
case
https://bugs.webkit.org/attachment.cgi?id=88532&action=review
------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
Okay, I'll break this down in the hopes of speeding up the review process. This
first patch just fixes some cases for !USE(EXPORT_MACROS) where
WTF/JS_EXPORT_PRIVATE were erroneously defined. They should only be defined to
the appropriate export / import macro when using the export macros.
More information about the webkit-reviews
mailing list