[webkit-reviews] review canceled: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 87659] Step 2, part 1: same as previous patch, just updated to deal with bit rot
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 6 15:31:12 PDT 2011
Kevin Ollivier <kevino at theolliviers.com> has canceled Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551
Attachment 87659: Step 2, part 1: same as previous patch, just updated to deal
with bit rot
https://bugs.webkit.org/attachment.cgi?id=87659&action=review
------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
Okay, I'll break this down in the hopes of speeding up the review process. This
first patch just fixes some cases for !USE(EXPORT_MACROS) where
WTF/JS_EXPORT_PRIVATE were erroneously defined. They should only be defined to
the appropriate export / import macro when using the export macros.
More information about the webkit-reviews
mailing list