[webkit-reviews] review granted: [Bug 50661] Convert <meter> shadow DOM to a DOM-based shadow. : [Attachment 88132] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 50661: Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661

Attachment 88132: Patch
https://bugs.webkit.org/attachment.cgi?id=88132&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88132&action=review

lovely, with one more tweak:

> Source/WebCore/html/shadow/MeterShadowElement.cpp:60
> +    return meterRenderer && meterRenderer->shouldHaveParts() &&
HTMLDivElement::rendererIsNeeded(style);

I think you can kill RenderMeter::shouldHaveParts altogether and call
RenderTheme here directly:

return document()->page()->theme()->supportsMeter(style->appearance());