[webkit-reviews] review granted: [Bug 57562] Introduce EventDispatchMediator abstraction, which encapsulate all non-trivial logic around firing a specific type of an event. : [Attachment 87813] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 14:37:38 PDT 2011


Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 57562: Introduce EventDispatchMediator abstraction, which encapsulate all
non-trivial logic around firing a specific type of an event.
https://bugs.webkit.org/show_bug.cgi?id=57562

Attachment 87813: Patch
https://bugs.webkit.org/attachment.cgi?id=87813&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87813&action=review

> Source/WebCore/dom/Event.h:196
> +class EventDispatchMediator {

We usually have one class per file.  However, EventDispatchMediator looks
pretty trivial, so maybe it makes sense to keep here...

> Source/WebCore/dom/Event.h:198
> +    EventDispatchMediator(PassRefPtr<Event>);

Please add the explicit keyword.  The style checker should really complain
about that.

> Source/WebCore/dom/KeyboardEvent.h:119
> +    KeyboardEventDispatchMediator(PassRefPtr<KeyboardEvent>);

explicit


More information about the webkit-reviews mailing list