[webkit-reviews] review granted: [Bug 56695] Make StructureChain GC allocated : [Attachment 88073] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 56695: Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695

Attachment 88073: Patch
https://bugs.webkit.org/attachment.cgi?id=88073&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88073&action=review

Hard to tell just by looking if this is correct, but if the tests pass, it look
generally OK.

> Source/JavaScriptCore/runtime/Structure.h:112
> +	       if (m_prototype)
> +		   markStack.append(&m_prototype);

Just noticed this, although it's not new in your patch:

It would be nice to get rid of the concept of a JSValue() prototype, and use
jsNull() instead, to get rid of this branch.