[webkit-reviews] review denied: [Bug 57328] Introspection: missing signal annotations : [Attachment 87305] add signal annotations

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied  review:
Bug 57328: Introspection: missing signal annotations
https://bugs.webkit.org/show_bug.cgi?id=57328

Attachment 87305: add signal annotations
https://bugs.webkit.org/attachment.cgi?id=87305&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Thanks for the patch! To land the patch we need a ChangeLog entry you can
generate with ./Tools/Scripts/prepare-ChangeLog (use --git-commit HEAD if you
are using git and committed the changes). Also, you can keep your copyright,
the WebKit project does not require copyright assignment, feel free to add your
name to the header.

Now for comments on the content: the addition of documentation for
hovering-over-link is welcome. Do we really need to add documentation to
set-scroll-adjustments, since it's actually being overriden from GtkWidget? As
for the other signals, they are undocumented on purpose - their design is not
finished, and they only exist for internal purposes at this point (for the test
runner). These signals may change, so perhaps we would need to annotate them to
be ignored. Marking r- for these reasons and for lack of ChangeLog, thanks for
working on this!