[webkit-reviews] review granted: [Bug 57706] [Qt] Radio buttons are showing wrong with mobile theme : [Attachment 87979] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 3 23:32:43 PDT 2011

Csaba Osztrogonac <ossy at webkit.org> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 57706: [Qt] Radio buttons are showing wrong with mobile theme

Attachment 87979: Patch

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87979&action=review

AFAIK we can test it, only if QT_MOBILE_THEME is true, but it isn't set by

Please fix the typo and the variable name before landing, otherwise LGTM, r=me.

> Source/WebCore/platform/qt/QtMobileWebStyle.cpp:92
> +    // get minor size to do not paint a wide elipse
> +    qreal side = qMin(size.width(), size.height());

// ... ellipse ...
radioButtonSize would be better name

> Source/WebCore/platform/qt/QtMobileWebStyle.cpp:94
> +    QRect rect = QRect(QPoint(1, 1), QSize(side - 2, side - 2));


More information about the webkit-reviews mailing list