[webkit-reviews] review denied: [Bug 57717] Convert use of raw pointers to RefPtr in using Cairo : [Attachment 88012] Proposed Patch3

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Joone Hur <joone at kldp.org>'s request
for review:
Bug 57717: Convert use of raw pointers to RefPtr in using Cairo
https://bugs.webkit.org/show_bug.cgi?id=57717

Attachment 88012: Proposed Patch3
https://bugs.webkit.org/attachment.cgi?id=88012&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88012&action=review

This patch makes my heart sing!  Unfortunately I think it also will make
WebCore crash (in the one case I pointed out.

> Source/WebCore/platform/graphics/cairo/ContextShadowCairo.cpp:82
> +    scratchBuffer = adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32,
width, height));
> +    return scratchBuffer.get();

Um.  This isn't going to work, or?  I think you want to return a PassRefPtr
here.