[webkit-reviews] review granted: [Bug 57584] [Chromium] Text anti-aliasing fails when rendering text with shadow : [Attachment 87864] Fixed style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 1 09:45:44 PDT 2011

Kenneth Russell <kbr at google.com> has granted Justin Novosad
<junov at chromium.org>'s request for review:
Bug 57584: [Chromium] Text anti-aliasing fails when rendering text with shadow

Attachment 87864: Fixed style

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87864&action=review

The logic changes and test expectations updates look good. One minor style
issue, just FYI, not necessary to fix. cq+'ing as is.

> Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:389
> +    if (!alpha && graphicsContext->platformContext()->getStrokeStyle() ==
> +	   && !graphicsContext->hasShadow()) {

WebKit style doesn't have a line length, so this would be easier to read if it
were all one line.

More information about the webkit-reviews mailing list