[webkit-reviews] review granted: [Bug 57611] [GTK] Do not destroy WorkQueue event sources unless they have been cancelled : [Attachment 87836] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 57611: [GTK] Do not destroy WorkQueue event sources unless they have been
cancelled
https://bugs.webkit.org/show_bug.cgi?id=57611

Attachment 87836: Patch
https://bugs.webkit.org/attachment.cgi?id=87836&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87836&action=review

Nice.

> Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:61
>	       if (!queue->m_isValid)
> -		   return FALSE;
> +		   return;

It appears that Mac does not cancel the source either if the queue is invalid.
Do you know in what cases this can happen?