[webkit-reviews] review granted: [Bug 45845] [chromium] WebViewImpl should not destroy accelerated compositor when compositing is not needed : [Attachment 69075] patch fixing previous issues

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 45845: [chromium] WebViewImpl should not destroy accelerated compositor
when compositing is not needed
https://bugs.webkit.org/show_bug.cgi?id=45845

Attachment 69075: patch fixing previous issues
https://bugs.webkit.org/attachment.cgi?id=69075&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Basically looks fine. WebKit style prefers early returns, so it might be better
to restructure things to peel off cases one at a time and return. For example,

if (!active) {
    m_isAcceleratedCompositingActive = false;
    return;
}

if (m_layerRenderer) {
    m_isAcceleratedCompositingActive = true;
    return;
}

and so on.