[webkit-reviews] review granted: [Bug 46744] [Qt] Text drawing taints GraphicsContext's QPainter::pen() : [Attachment 69082] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 28 12:07:20 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 46744: [Qt] Text drawing taints GraphicsContext's QPainter::pen()
https://bugs.webkit.org/show_bug.cgi?id=46744
Attachment 69082: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=69082&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69082&action=review
LGTM
> WebCore/platform/graphics/qt/FontQt.cpp:212
> + QPen oldPen = p->pen();
Persoannly I like previousPen better than old.
More information about the webkit-reviews
mailing list