[webkit-reviews] review denied: [Bug 46224] Reproducible Crash when Inspector Open in CSSStyleSelector::loadPendingImages() : [Attachment 68993] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 46224: Reproducible Crash when Inspector Open in
CSSStyleSelector::loadPendingImages()
https://bugs.webkit.org/show_bug.cgi?id=46224

Attachment 68993: Patch
https://bugs.webkit.org/attachment.cgi?id=68993&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This is likely to break inspector/ tests. We rely upon
WebInspector.dispatchMessageFromBackend's (WebInspector.dispatch's) timer that
is delaying the dispatch job. See inspector.js for the code. Your change is
good, especially accompanied with this unnecessary timer removal. But our
testing harness uses pending message counter to make sure all async jobs are
dispatched (same dispatch method in js). In addition to your change you would
need to notify front-end once your queue is empty. We do this in chromium.

... or if the tests are passing, feel free to land it. I'll have to understand
why they are passing though.