[webkit-reviews] review granted: [Bug 46737] Implement PluginProxy::destroy : [Attachment 69071] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 28 11:01:51 PDT 2010
Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 46737: Implement PluginProxy::destroy
https://bugs.webkit.org/show_bug.cgi?id=46737
Attachment 69071: Patch
https://bugs.webkit.org/attachment.cgi?id=69071&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69071&action=review
> WebKit2/PluginProcess/WebProcessConnection.messages.in:30
> + # Destroys the plug-in instance with the given instance ID.
> + DestroyPlugin(uint64_t pluginInstanceID) -> ()
I worry that this doesn't make it clear enough that this is a sync message.
Maybe we need to make the syntax more explicit.
More information about the webkit-reviews
mailing list