[webkit-reviews] review denied: [Bug 46724] Web Inspector: move pauseOnExceptionState under control of InspectorState : [Attachment 69053] [patch] initial version.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 46724: Web Inspector: move pauseOnExceptionState under control of
InspectorState
https://bugs.webkit.org/show_bug.cgi?id=46724

Attachment 69053: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=69053&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69053&action=review

> WebCore/inspector/InspectorController.cpp:263
> +    (*state)->setNumber(pauseOnExceptionsStateStateName,
ScriptDebugServer::shared().pauseOnExceptionsState());

This is the only usage of ScriptDebugServer left in the IC, I should have
removed when I was extracting InspectorDebuggerAgent. Could you move this
accessor into Inspector  debugger agent and check here if the agent is present,
it should cover both cases of debugger always enabled and debugger enabled
manually.

> WebCore/inspector/front-end/inspector.js:595
> +	   if ("updatePauseOnExceptionsState" in inspectorState)

you check for presence of one name but then access another field