[webkit-reviews] review granted: [Bug 45166] Web Inspector: implement go-to-line feature : [Attachment 68894] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 27 06:04:22 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 45166: Web Inspector: implement go-to-line feature
https://bugs.webkit.org/show_bug.cgi?id=45166

Attachment 68894: Patch
https://bugs.webkit.org/attachment.cgi?id=68894&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68894&action=review

Please add this to VC project as well.

> WebCore/inspector/front-end/GoToLineDialog.js:31
> +WebInspector.GoToLineDialog = function(view)

It'd nice to factor it out into generic dialog.

> WebCore/inspector/front-end/GoToLineDialog.js:44
> +    var labelText = linesCount ? " (1 - " + linesCount + ")" : "";

Should be localizable.


More information about the webkit-reviews mailing list