[webkit-reviews] review granted: [Bug 46611] Web Inspector: split InspectorTimelineAgent into two parts. : [Attachment 68895] [patch] second iteration

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 46611: Web Inspector: split InspectorTimelineAgent into two parts.
https://bugs.webkit.org/show_bug.cgi?id=46611

Attachment 68895: [patch] second iteration
https://bugs.webkit.org/attachment.cgi?id=68895&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68895&action=review

> WebCore/inspector/InspectorTimelineAgent.cpp:49
> +class InspectorTimelineAgent2 : ScriptGCEventListener, public Noncopyable {

I'd rather call this one InspectorTimeline (leave the name) + Call new one
InspectorInstrumentation.

> WebCore/inspector/InspectorTimelineAgent.cpp:67
> +	   : record(record), data(data), children(children), type(type)

Use WebKit indentation.

> WebCore/inspector/InspectorTimelineAgent.cpp:79
> +	   : startTime(startTime), endTime(endTime),
collectedBytes(collectedBytes)

ditto