[webkit-reviews] review granted: [Bug 46514] Add WTF::StringHasher::createBlobHash : [Attachment 68751] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 26 21:47:56 PDT 2010


Adam Barth <abarth at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 46514: Add WTF::StringHasher::createBlobHash
https://bugs.webkit.org/show_bug.cgi?id=46514

Attachment 68751: Patch
https://bugs.webkit.org/attachment.cgi?id=68751&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68751&action=review

Holy copy/paste code batman.

> JavaScriptCore/wtf/StringHashFunctions.h:139
> +	   COMPILE_ASSERT(!(length % 4), length_must_be_a_multible_of_four);

multible => multiple


More information about the webkit-reviews mailing list