[webkit-reviews] review granted: [Bug 46516] Use WTF::StringHasher for hashing MappedAttributeKey : [Attachment 68753] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 46516: Use WTF::StringHasher for hashing MappedAttributeKey
https://bugs.webkit.org/show_bug.cgi?id=46516

Attachment 68753: Patch
https://bugs.webkit.org/attachment.cgi?id=68753&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68753&action=review

Do we want to run any performance tests to make sure we're not regressing here?


> WebCore/dom/StyledElement.cpp:-456
> -    // This avoids ever returning a hash code of 0, since that is used to
> -    // signal "hash not computed yet", using a value that is likely to be
> -    // effectively the same as 0 when the low bits are masked
> -    if (hash == 0)
> -	   hash = 0x80000000;

Does StringHasher respect this?