[webkit-reviews] review denied: [Bug 46509] Add operator == for AtomicString and Vector<Uchar> : [Attachment 68799] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied  review:
Bug 46509: Add operator == for AtomicString and Vector<Uchar>
https://bugs.webkit.org/show_bug.cgi?id=46509

Attachment 68799: Patch
https://bugs.webkit.org/attachment.cgi?id=68799&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68799&action=review

> JavaScriptCore/wtf/text/AtomicString.h:129
> +inline bool operator==(const AtomicString& a, const Vector<UChar>& b) {
return a.impl() && equal(a.impl(), b.data(), b.size()); }

Oops! This won’t compile. The equal function this calls is inside
AtomicString.cpp and private to the cpp file, not exposed to the header at all.