[webkit-reviews] review granted: [Bug 46546] Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:] : [Attachment 68797] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 24 18:42:41 PDT 2010


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 46546: Implement WebKit2 callback equivalent to -[WebUIDelegate
mouseDidMoveOverElement:modifierFlags:]
https://bugs.webkit.org/show_bug.cgi?id=46546

Attachment 68797: Patch
https://bugs.webkit.org/attachment.cgi?id=68797&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68797&action=review

Looks like you broke Qt. If you deal with that, r=me.

> WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:43
> +    RefPtr<InjectedBundleNodeHandle> nodeHandle =
toWK(hitTestResultRef)->nodeHandle();
> +    return toRef(nodeHandle.get());

Do you need a local variable here?


More information about the webkit-reviews mailing list