[webkit-reviews] review granted: [Bug 45796] Remaining discrepancies in piecewise text measurement : [Attachment 68383] patch to width iterator

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Brad Moore <bradm at apple.com>'s request for review:
Bug 45796: Remaining discrepancies in piecewise text measurement
https://bugs.webkit.org/show_bug.cgi?id=45796

Attachment 68383: patch to width iterator
https://bugs.webkit.org/attachment.cgi?id=68383&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=68383&action=review

> WebCore/platform/graphics/WidthIterator.cpp:224
> +	       ASSERT(widthSinceLastRounding == 0);

Like the style checker mentioned, WebKit style is to write this as
ASSERT(!widthSinceLastRounding);