[webkit-reviews] review granted: [Bug 46276] Web Inspector: export raw data from Timeline panel. : [Attachment 68390] [patch] initial version.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 46276: Web Inspector: export raw data from Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=46276

Attachment 68390: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=68390&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68390&action=review

> WebCore/inspector/front-end/TimelinePanel.js:88
> +    this._exportToFileTitleText = WebInspector.UIString("Export to file");

Why not just use it inplace?

> WebCore/inspector/front-end/TimelinePanel.js:297
> +	   objectForExport.version = /AppleWebKit\/([^
]+)/.exec(window.navigator.userAgent)[0];

What is the version format? Is it consistent between browsers?