[webkit-reviews] review requested: [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text : [Attachment 68346] Single patch for fixing this bug

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25898: [Gtk] object:text-changed events should be emitted for entries and
password text
https://bugs.webkit.org/show_bug.cgi?id=25898

Attachment 68346: Single patch for fixing this bug
https://bugs.webkit.org/attachment.cgi?id=68346&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #89)
> (In reply to comment #88)
> 
> AccessibilityRenderObject.cpp is not exported as a header, and I don't think
it should be.
> 
> Really, anyone using Accessibility in WebKit, should only know about
AXObjectCache and AccessibilityObject.

That makes sense, and now that I look in AXObjectCache.h, I see the new
functions I'm adding there are the only ones requiring
AccessibilityRenderObject's as parameters, instead of just
AccessibilityObject's.

Hence, attaching a new patch (hope this is the last strike!) where I changed
the type of those parameters, letting the platform specific code to do the
additional checks to make sure an AccessibilityRenderObject is being passed to
nodeTextChangePlatformNotification in the case of GTK.

Sorry for so much hassle with this.